pxcloud/spice
6
0
Fork 0
mirror of https://gitlab.uni-freiburg.de/opensourcevdi/spice synced 2026-08-08 09:04:33 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

usbredir: Ensure that our msg_rcv_buf is not used re-entrantly

Browse Source 
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
This commit is contained in:
Hans de Goede 2011-08-24 16:25:38 +02:00
parent e9d6e86fc8
commit e1570ce519
1 changed files with 12 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
server/usbredir.c
View File

@ -22,6 +22,8 @@
#include <config.h>
#endif
#include <assert.h>
#include "server/char_device.h"
#include "server/red_channel.h"
#include "server/reds.h"
@ -44,6 +46,7 @@ typedef struct UsbRedirState {
UsbRedirPipeItem *pipe_item;
uint8_t *rcv_buf;
uint32_t rcv_buf_size;
int rcv_buf_in_use;
} UsbRedirState;
typedef struct UsbRedirChannel {
@ -140,18 +143,27 @@ static uint8_t *usbredir_red_channel_alloc_msg_rcv_buf(RedChannelClient *rcc,
state = SPICE_CONTAINEROF(rcc->channel, UsbRedirChannel, base)->state;
assert(!state->rcv_buf_in_use);
if (msg_header->size > state->rcv_buf_size) {
state->rcv_buf = spice_realloc(state->rcv_buf, msg_header->size);
state->rcv_buf_size = msg_header->size;
}
state->rcv_buf_in_use = 1;
return state->rcv_buf;
}
static void usbredir_red_channel_release_msg_rcv_buf(RedChannelClient *rcc,
SpiceDataHeader *msg_header, uint8_t *msg)
{
UsbRedirState *state;
state = SPICE_CONTAINEROF(rcc->channel, UsbRedirChannel, base)->state;
/* NOOP, we re-use the buffer every time and only free it on destruction */
state->rcv_buf_in_use = 0;
}
static void usbredir_red_channel_hold_pipe_item(RedChannelClient *rcc,