pxcloud/spice
6
0
Fork 0
mirror of https://gitlab.uni-freiburg.de/opensourcevdi/spice synced 2026-08-08 09:04:33 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

spicec-x11: Remove a race window in selection ownership release code

Browse Source 
Well almost remove it, it was possible that another x11 app would acquire
selection ownership, and we would receive a release message from the
agent before having processed the xselection ownership change event.

Then we would set the selection owner to none, overriding the new owner.
As the comment in the patch indicates there still is a minute window left
where something similar can happen after this patch. Nothing we can do
about that (I blame the libX11 selection API).
This commit is contained in:
Hans de Goede 2010-10-06 16:14:06 +02:00
parent 7b84db7a74
commit dddb6ad48a
1 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
client/x11/platform.cpp
View File

@ -3466,7 +3466,15 @@ void Platform::on_clipboard_release()
{
XEvent event;
if (XGetSelectionOwner(x_display, clipboard_prop) != platform_win) {
LOG_INFO("Platform::on_clipboard_release() called while not selection owner");
return;
}
/* Note there is a small race window here where another x11 app could
acquire selection ownership and we kick it off again, nothing we
can do about that :( */
XSetSelectionOwner(x_display, clipboard_prop, None, CurrentTime);
/* Make sure we process the XFixesSetSelectionOwnerNotify event caused
by this, so we don't end up changing the clipboard owner to none, after
it has already been re-owned because this event is still pending. */