pxcloud/spice
5
0
Fork 0
mirror of https://gitlab.uni-freiburg.de/opensourcevdi/spice synced 2025-12-26 22:48:19 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

red-channel-client: Add some comment on the flush code

Browse Source 
Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
Acked-by: Victor Toso <victortoso@redhat.com>,
This commit is contained in:
Frediano Ziglio 2019-05-22 05:10:23 +01:00
parent 2e357a9b7b
commit cee05ca8ac
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
server/red-channel-client.c
View File

@ -1319,6 +1319,9 @@ void red_channel_client_push(RedChannelClient *rcc)
/* prepare_pipe_add() will reenable WRITE events when the rcc->priv->pipe is empty
* red_channel_client_ack_zero_messages_window() will reenable WRITE events
* if we were waiting for acks to be received
* If we don't remove WRITE if we are waiting for ack we will be keep
* notified that we can write and we then exit (see pipe_item_get) as we
* are waiting for the ack consuming CPU in a tight loop
*/
if ((red_channel_client_no_item_being_sent(rcc) && g_queue_is_empty(&rcc->priv->pipe)) ||
red_channel_client_waiting_for_ack(rcc)) {
@ -1326,6 +1329,9 @@ void red_channel_client_push(RedChannelClient *rcc)
/* channel has no pending data to send so now we can flush data in
* order to avoid data stall into buffers in case of manual
* flushing
* We need to flush also in case of ack as it is possible
* that for a long train of small messages the message that would
* cause the client to send the ack is still in the queue
*/
red_stream_flush(rcc->priv->stream);
}