pxcloud/spice
5
0
Fork 0
mirror of https://gitlab.uni-freiburg.de/opensourcevdi/spice synced 2025-12-26 14:41:25 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

red-record-qxl: child_output_setup: remove fcntl call

Browse Source 
man 2 dup2 specifies:
  The close-on-exec flag (FD_CLOEXEC; see  fcntl(2))  for
  the duplicate descriptor is off.

Since the purpose of the fcntl call is to turn off FD_CLOEXEC
flag, and it's already done, just remove this call.

Suggested-by: Frediano Ziglio <fziglio@redhat.com>
Signed-off-by: Uri Lublin <uril@redhat.com>
Acked-by: Frediano Ziglio <fziglio@redhat.com>
This commit is contained in:
Uri Lublin 2016-12-06 18:06:30 +02:00 committed by Frediano Ziglio
parent 4be1a6ec8c
commit c3d5689f4a
1 changed files with 0 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
server/red-record-qxl.c
View File

@ -21,7 +21,6 @@
#include <stdbool.h>
#include <inttypes.h>
#include <fcntl.h>
#include <glib.h>
#include "red-common.h"
#include "memslot.h"
@ -851,9 +850,6 @@ static void child_output_setup(gpointer user_data)
continue;
}
close(fd);
// make sure file is not closed calling exec()
fcntl(STDOUT_FILENO, F_SETFD, 0);
}
RedRecord *red_record_new(const char *filename)