mirror of
https://gitlab.uni-freiburg.de/opensourcevdi/spice
synced 2026-01-05 04:02:43 +00:00
red-replay-qxl: Fix replay on 32 bit systems
On 32 systems pointers are 32 bit while QXLPHYSICAL is always 64 bit. Using pointer -> intptr_t -> QXLPHYSICAL conversion cause pointers to have higher 32 bit set to 1 if the address is >= 0x80000000. This is possible depending on address space. The QXLPHYSICAL is split in 3 sections: - slot ID; - generation; - virtual address. Current utility using record file (spice-server-replay) set slot ID and generation to 0 so if the higher bits become all 1 slot ID and generation won't be 0 causing the utility to fail. Use pointer -> uintptr_t -> QXLPHYSICAL conversion to avoid this issue. Note that for opposite conversion (QXLPHYSICAL_TO_PTR) the conversion does not change, type is changed just for consistency. Signed-off-by: Frediano Ziglio <fziglio@redhat.com> Acked-by: Snir Sheriber <ssheribe@redhat.com>
This commit is contained in:
parent
3ebc6d4a43
commit
c289a6eee3
@ -29,8 +29,8 @@
|
||||
#include "memslot.h"
|
||||
#include "red-parse-qxl.h"
|
||||
|
||||
#define QXLPHYSICAL_FROM_PTR(ptr) ((QXLPHYSICAL)(intptr_t)(ptr))
|
||||
#define QXLPHYSICAL_TO_PTR(phy) ((void*)(intptr_t)(phy))
|
||||
#define QXLPHYSICAL_FROM_PTR(ptr) ((QXLPHYSICAL)(uintptr_t)(ptr))
|
||||
#define QXLPHYSICAL_TO_PTR(phy) ((void*)(uintptr_t)(phy))
|
||||
|
||||
typedef enum {
|
||||
REPLAY_OK = 0,
|
||||
|
||||
Loading…
Reference in New Issue
Block a user