From bde8ef5a4e5d04beb50d158e37bf7665419f6eee Mon Sep 17 00:00:00 2001 From: Frediano Ziglio Date: Tue, 12 Dec 2017 17:20:39 +0000 Subject: [PATCH] stat-file: Protect flags field with atomic operation Coverity complaint that this field should be protected by a mutex as other accesses are with the mutex locked. Use atomic operation. Not in an hot path in any case. Signed-off-by: Frediano Ziglio Acked-by: Uri Lublin --- server/stat-file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/server/stat-file.c b/server/stat-file.c index 2797fd73..45dece65 100644 --- a/server/stat-file.c +++ b/server/stat-file.c @@ -190,7 +190,7 @@ stat_file_add_counter(RedStatFile *stat_file, StatNodeRef parent, const char *na return NULL; } node = &stat_file->stat->nodes[ref]; - node->flags |= SPICE_STAT_NODE_FLAG_VALUE; + __sync_or_and_fetch(&node->flags, SPICE_STAT_NODE_FLAG_VALUE); return &node->value; }