From b8a1de32749fe536b331ca69c04e4d9b85e7e30d Mon Sep 17 00:00:00 2001 From: Christophe Fergeau Date: Tue, 19 Jul 2011 13:26:05 +0200 Subject: [PATCH] client: add missing "," in option list In commit 44073d1b38e2 - client: improve WAN option description one "," was missing at the end of the line. Since the next argument was a string too, gcc silently concatenated them, and thanks to C++ polymorphic functions, the compiler didn't complain about the missing argument, so it went unnoticed. The effects are pretty bad though, since it prevents spicec from running because it thinks command line parsing fails. --- client/application.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/client/application.cpp b/client/application.cpp index 18101a59..5ebcce7f 100644 --- a/client/application.cpp +++ b/client/application.cpp @@ -2276,7 +2276,7 @@ bool Application::process_cmd_line(int argc, char** argv, bool &full_screen) parser.add(SPICE_OPT_CANVAS_TYPE, "canvas-type", "set rendering canvas", "canvas_type", true); parser.set_multi(SPICE_OPT_CANVAS_TYPE, ','); - parser.add(SPICE_OPT_DISPLAY_COLOR_DEPTH, "color-depth", "guest display color depth (if supported by the guest vdagent)" + parser.add(SPICE_OPT_DISPLAY_COLOR_DEPTH, "color-depth", "guest display color depth (if supported by the guest vdagent)", "16/32", true); parser.add(SPICE_OPT_DISABLE_DISPLAY_EFFECTS, "disable-effects",