From a19f51265c04bfa33eaa07f499eda35a55844a8b Mon Sep 17 00:00:00 2001 From: Hans de Goede Date: Fri, 1 Apr 2011 10:34:24 +0200 Subject: [PATCH] server: break read_from_vdi_port loop if the guest gets disconnected read_from_vdi_port calls dispatch_vdi_port data, which will disconnect the guest agent if it sends invalid data. It would then try to read more data from the disconnected guest agent resulting in a NULL ptr dereference, this patch fixes this. --- server/reds.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/server/reds.c b/server/reds.c index b286809e..088683b6 100644 --- a/server/reds.c +++ b/server/reds.c @@ -1292,7 +1292,7 @@ static int read_from_vdi_port(void) } sif = SPICE_CONTAINEROF(vdagent->base.sif, SpiceCharDeviceInterface, base); - while (!quit_loop) { + while (!quit_loop && vdagent) { switch (state->read_state) { case VDI_PORT_READ_STATE_READ_HADER: n = sif->read(vdagent, state->recive_pos, state->recive_len);