pxcloud/spice
5
0
Fork 0
mirror of https://gitlab.uni-freiburg.de/opensourcevdi/spice synced 2025-12-31 02:23:45 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

client/windows: fix SetClipboardViewer error handling rhbz#786554

Browse Source 
MSDN says the following about SetClipboardViewer(): "If an error occurs or there
are no other windows in the clipboard viewer chain, the return value is NULL".
Seems like the buggy case was "no other windows in the clipboard viewer chain",
which explains the 3rd party clipboard manager workaround detailed in the bug
description.

It also seems like SetClipboardViewer() does not clear the error state on
succcess. Calling SetLastError(0) before SetClipboardViewer() seems to solves
this issue.

Since we could not reproduce the bug on our env, the customer has verified on
several of their systems that a private build resolved the issue.
This commit is contained in:
Arnon Gilboa 2012-03-01 13:06:24 +02:00
parent d82ac68c5a
commit 9eb73318ce
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
client/windows/platform.cpp
View File

@ -249,6 +249,7 @@ static void create_message_wind()
{
WNDCLASSEX wclass;
ATOM class_atom;
DWORD err;
const LPCWSTR class_name = L"spicec_platform_wclass";
@ -272,9 +273,9 @@ static void create_message_wind()
if (!(platform_win = CreateWindow(class_name, L"", 0, 0, 0, 0, 0, NULL, NULL, instance, NULL))) {
THROW("create message window failed");
}
if (!(next_clipboard_viewer_win = SetClipboardViewer(platform_win)) && GetLastError()) {
THROW("set clipboard viewer failed");
SetLastError(0);
if (!(next_clipboard_viewer_win = SetClipboardViewer(platform_win)) && (err = GetLastError())) {
THROW("set clipboard viewer failed %u", err);
}
if (!(clipboard_event = CreateEvent(NULL, FALSE, FALSE, NULL))) {
THROW("create clipboard event failed");