pxcloud/spice
6
0
Fork 0
mirror of https://gitlab.uni-freiburg.de/opensourcevdi/spice synced 2026-08-06 15:34:29 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

red-parse-qxl: Reset mask attributes if brush image is missing

Browse Source 
The attributes in this case are not used to apply the mask.
Doing so avoid sending garbage from the guest which usually
don't initialise the memory in case the mask is missing.
Guest should have cleared these bytes by its own however doing so
on the server fixes the problem too. Considering that these
command should not appears in newer OSes it's surely not a hot path
code.
These garbage came from video memory of the guest so they don't
contain sensitive data.

This fixes https://gitlab.freedesktop.org/spice/spice-server/issues/25.

Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
Acked-by: Snir Sheriber <ssheribe@redhat.com>
This commit is contained in:
Frediano Ziglio 2019-06-01 22:03:07 +01:00
parent 0591a09ca5
commit 94611ac175
1 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
server/red-parse-qxl.c
View File

@ -626,9 +626,15 @@ static void red_put_brush(SpiceBrush *red)
static void red_get_qmask_ptr(RedMemSlotInfo *slots, int group_id,
SpiceQMask *red, QXLQMask *qxl, uint32_t flags)
{
red->flags = qxl->flags;
red_get_point_ptr(&red->pos, &qxl->pos);
red->bitmap = red_get_image(slots, group_id, qxl->bitmap, flags, true);
if (red->bitmap) {
red->flags = qxl->flags;
red_get_point_ptr(&red->pos, &qxl->pos);
} else {
red->flags = 0;
red->pos.x = 0;
red->pos.y = 0;
}
}
static void red_put_qmask(SpiceQMask *red)