From 8e593b55cf28566d46687f25802ac6aa24ca8302 Mon Sep 17 00:00:00 2001
From: Uri Lublin <uril@redhat.com>
Date: Tue, 6 Jun 2017 15:10:22 +0300
Subject: [PATCH] init ssl connection: return quickly if link is null

Under error: 'link' fields are being accessed, so it's
wrong to goto error with link == NULL.

Instead, return immediately.

Found by coverity.

Signed-off-by: Uri Lublin <uril@redhat.com>
Acked-by: Pavel Grunt <pgrunt@redhat.com>
---
 server/reds.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/server/reds.c b/server/reds.c
index 034cd10d..8abfbda5 100644
--- a/server/reds.c
+++ b/server/reds.c
@@ -2461,8 +2461,9 @@ static RedLinkInfo *reds_init_client_ssl_connection(RedsState *reds, int socket)
     int ssl_status;
 
     link = reds_init_client_connection(reds, socket);
-    if (link == NULL)
-        goto error;
+    if (link == NULL) {
+        return NULL;
+    }
 
     ssl_status = reds_stream_enable_ssl(link->stream, reds->ctx);
     switch (ssl_status) {