From 89c5d062d6c496e5ff669646eb7b85e5343dce1d Mon Sep 17 00:00:00 2001 From: Frediano Ziglio Date: Sat, 2 Dec 2017 15:59:48 +0000 Subject: [PATCH] reds: Fix wrong assert RedVDIReadBuf::data is a static allocated buffer so checking for NULL on it is useless. It would be NULL only if RedVDIReadBuf pointer would be the opposite, in value, of the offset of data field into it. Signed-off-by: Frediano Ziglio Acked-by: Victor Toso --- server/reds.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/server/reds.c b/server/reds.c index 40c82ccc..4ed121a1 100644 --- a/server/reds.c +++ b/server/reds.c @@ -1242,7 +1242,7 @@ void reds_on_main_channel_migrate(RedsState *reds, MainChannelClient *mcc) if (agent_dev->priv->read_state != VDI_PORT_READ_STATE_READ_DATA) { return; } - spice_assert(agent_dev->priv->current_read_buf->data && + spice_assert(agent_dev->priv->current_read_buf && agent_dev->priv->receive_pos > agent_dev->priv->current_read_buf->data); read_data_len = agent_dev->priv->receive_pos - agent_dev->priv->current_read_buf->data;