From 7af613362a2e320574dc688fad98294e90f029cc Mon Sep 17 00:00:00 2001 From: "Daniel P. Berrange" Date: Tue, 13 Mar 2012 16:39:45 +0000 Subject: [PATCH] VSCMsgHeader.reader_id is unsigned, so don't check for >= 0 * server/smartcard.c: Fix assertion to not check for >= 0 on unsigned variable Signed-off-by: Daniel P. Berrange --- server/smartcard.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/server/smartcard.c b/server/smartcard.c index 805cb6e1..eb2823aa 100644 --- a/server/smartcard.c +++ b/server/smartcard.c @@ -428,8 +428,7 @@ static void smartcard_channel_write_to_reader(VSCMsgHeader *vheader) uint32_t n; uint32_t actual_length = vheader->length; - spice_assert(vheader->reader_id >= 0 && - vheader->reader_id <= g_smartcard_readers.num); + spice_assert(vheader->reader_id <= g_smartcard_readers.num); sin = g_smartcard_readers.sin[vheader->reader_id]; sif = SPICE_CONTAINEROF(sin->base.sif, SpiceCharDeviceInterface, base); /* protocol requires messages to be in network endianess */