pxcloud/spice
6
0
Fork 0
mirror of https://gitlab.uni-freiburg.de/opensourcevdi/spice synced 2026-08-07 18:34:19 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

red-channel: Remove red_channel_init_outgoing_messages_window

Browse Source 
This function does not make much sense anymore.
Is called by RedVmcChannel which doesn't use RedChannelClient ACKs
so the variable changed are not used.
Moreover, at red_vmc_channel_constructed() time, there will be no
clients yet, so red_channel_init_outgoing_messages() will be a no-op.

Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
Acked-by: Christophe Fergeau <cfergeau@redhat.com>
This commit is contained in:
Frediano Ziglio 2017-10-06 08:57:42 +01:00
parent 617479413e
commit 7a3bfedfbe
3 changed files with 0 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
server/red-channel.c
View File

@ -421,14 +421,6 @@ void red_channel_push(RedChannel *channel)
g_list_foreach(channel->priv->clients, (GFunc)red_channel_client_push, NULL);
}
// TODO: this function doesn't make sense because the window should be client (WAN/LAN)
// specific
void red_channel_init_outgoing_messages_window(RedChannel *channel)
{
g_list_foreach(channel->priv->clients,
(GFunc)red_channel_client_init_outgoing_messages_window, NULL);
}
void red_channel_pipes_add(RedChannel *channel, RedPipeItem *item)
{
RedChannelClient *rcc;

3
server/red-channel.h
View File

@ -157,9 +157,6 @@ void red_channel_destroy(RedChannel *channel);
/* return true if all the channel clients support the cap */
bool red_channel_test_remote_cap(RedChannel *channel, uint32_t cap);
/* should be called when a new channel is ready to send messages */
void red_channel_init_outgoing_messages_window(RedChannel *channel);
// helper to push a new item to all channels
typedef RedPipeItem *(*new_pipe_item_t)(RedChannelClient *rcc, void *data, int num);
int red_channel_pipes_new_add(RedChannel *channel, new_pipe_item_t creator, void *data);

2
server/spicevmc.c
View File

@ -246,8 +246,6 @@ red_vmc_channel_constructed(GObject *object)
red_channel_set_cap(RED_CHANNEL(self), SPICE_SPICEVMC_CAP_DATA_COMPRESS_LZ4);
#endif
red_channel_init_outgoing_messages_window(RED_CHANNEL(self));
reds_register_channel(reds, RED_CHANNEL(self));
}