pxcloud/spice
6
0
Fork 0
mirror of https://gitlab.uni-freiburg.de/opensourcevdi/spice synced 2026-08-12 19:18:11 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

replay: remove a message that could be caused by a race condition

Browse Source 
The req_cmd_notification callback is called by spice-server when it
has processed all commands and wants to be notified (by a wakeup) that
new commands have been appended to the command queue.
Replay utility tries to fill the commands when it detects that
spice-server is trying to read commands but there are no more commands.
However, new commands are appended in a separate thread so if the main
red worker loop on spice-server is really tight this request can
happen.
Avoid printing any message on this condition, message will be appended
and loop woken up when replay code can do it.

Signed-by: Frediano Ziglio <figlio@redhat.com>
Acked-by: Jonathon Jongsma <jjongsma@redhat.com>
This commit is contained in:
Frediano Ziglio 2016-01-28 23:58:41 +00:00
parent 5c460de1a3
commit 77adbb7574
1 changed files with 0 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
server/tests/replay.c
View File

@ -183,12 +183,6 @@ static int get_command(QXLInstance *qin, QXLCommandExt *ext)
static int req_cmd_notification(QXLInstance *qin)
{
if (!started)
return TRUE;
g_printerr("id: %d, queue length: %d",
g_source_get_id(fill_source), g_async_queue_length(aqueue));
return TRUE;
}