pxcloud/spice
6
0
Fork 0
mirror of https://gitlab.uni-freiburg.de/opensourcevdi/spice synced 2026-08-06 11:27:27 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

red-qxl: remove cookie assertion on scanout

Browse Source 
The original check ensures we do not have an outstanding GL_DRAW. However,
in QEMU, there is no guarantee that a scanout cannot happen while the async
GL_DRAW has not returned a result yet. This introduces a race where if a
scanout is called while there is an outstanding GL_DRAW, QEMU will crash.

Signed-off-by: osy <osy@turing.llc>
Acked-by: Frediano Ziglio <freddy77@gmail.com>
This commit is contained in:
osy 2022-12-18 23:20:48 -08:00 committed by Michael Scherle
parent 62776e4953
commit 72b93e7d2c
1 changed files with 0 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
server/red-qxl.cpp
View File

@ -478,7 +478,6 @@ void spice_qxl_gl_draw_async(QXLInstance *qxl,
red_qxl_async_complete(qxl, cookie);
return;
}
spice_return_if_fail(qxl_state->gl_draw_cookie == GL_DRAW_COOKIE_INVALID);
qxl_state->gl_draw_cookie = cookie;
qxl_state->send_message(draw);