pxcloud/spice
5
0
Fork 0
mirror of https://gitlab.uni-freiburg.de/opensourcevdi/spice synced 2026-01-02 14:28:32 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

smartcard: set char device state

Browse Source 
Follow all other char devices implementation (spicevmc, agent,
stream-device) and set the char device state when
connected/disconnected. This allows qemu to discard writes, optimize a
bit the source polling, and will trigger HUP events.

See related qemu "char/spice: discard write() if backend is
disconnected".

Note: sif->state() should probably be handled at the char-device
level. I am not sure what the smartcard channel really brings over
plain spicevmc...

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Acked-by: Frediano Ziglio <fziglio@redhat.com>
This commit is contained in:
Marc-André Lureau 2018-08-07 17:26:18 +02:00 committed by Frediano Ziglio
parent 920dabdd88
commit 69a5cfc741
1 changed files with 15 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
server/smartcard.c
View File

@ -345,6 +345,11 @@ void smartcard_char_device_attach_client(SpiceCharDeviceInstance *char_device,
dev->priv->scc = NULL;
smartcard_channel_client_set_char_device(scc, NULL);
red_channel_client_disconnect(RED_CHANNEL_CLIENT(scc));
} else {
SpiceCharDeviceInterface *sif = spice_char_device_get_interface(char_device);
if (sif->state) {
sif->state(char_device, 1);
}
}
}
@ -377,11 +382,21 @@ gboolean smartcard_char_device_notify_reader_remove(RedCharDeviceSmartcard *dev)
void smartcard_char_device_detach_client(RedCharDeviceSmartcard *smartcard,
SmartCardChannelClient *scc)
{
SpiceCharDeviceInterface *sif;
SpiceCharDeviceInstance *sin;
g_object_get(smartcard, "sin", &sin, NULL);
sif = spice_char_device_get_interface(sin);
spice_assert(smartcard->priv->scc == scc);
red_char_device_client_remove(RED_CHAR_DEVICE(smartcard),
red_channel_client_get_client(RED_CHANNEL_CLIENT(scc)));
smartcard_channel_client_set_char_device(scc, NULL);
smartcard->priv->scc = NULL;
if (sif->state) {
sif->state(sin, 0);
}
}
SmartCardChannelClient* smartcard_char_device_get_client(RedCharDeviceSmartcard *smartcard)