pxcloud/spice
5
0
Fork 0
mirror of https://gitlab.uni-freiburg.de/opensourcevdi/spice synced 2025-12-27 23:49:04 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

clang-tidy: use const reference for loop

Browse Source 
Found with performance-for-range-copy

Avoids unnecessary copying when the loop does not modify the variable.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
Acked-by: Frediano Ziglio <freddy77@gmail.com>
This commit is contained in:
Rosen Penev 2020-10-05 02:49:51 -07:00 committed by Frediano Ziglio
parent e353f1a065
commit 68b0f3029d
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
server/reds.cpp
View File

@ -333,7 +333,7 @@ void reds_unregister_channel(RedsState *reds, RedChannel *channel)
RedChannel *reds_find_channel(RedsState *reds, uint32_t type, uint32_t id)
{
for (auto channel: reds->channels) {
for (const auto& channel: reds->channels) {
if (channel->type() == type && channel->id() == id) {
return channel.get();
}
@ -810,7 +810,7 @@ void reds_marshall_device_display_info(RedsState *reds, SpiceMarshaller *m)
}
// add the stream devices to the message
for (auto dev: reds->char_devices) {
for (const auto& dev: reds->char_devices) {
auto stream_dev = dynamic_cast<StreamDevice*>(dev.get());
if (stream_dev) {
const StreamDeviceDisplayInfo *info = stream_dev->get_device_display_info();
@ -1728,7 +1728,7 @@ static void reds_late_initialization(RedsState *reds)
}
// create stream channels for streaming devices
for (auto dev: reds->char_devices) {
for (const auto& dev: reds->char_devices) {
auto stream_dev = dynamic_cast<StreamDevice*>(dev.get());
if (stream_dev) {
stream_dev->create_channel();
@ -4244,7 +4244,7 @@ SPICE_GNUC_VISIBLE int spice_server_migrate_switch(SpiceServer *reds)
SPICE_GNUC_VISIBLE void spice_server_vm_start(SpiceServer *reds)
{
reds->vm_running = TRUE;
for (auto dev: reds->char_devices) {
for (const auto& dev: reds->char_devices) {
dev->start();
}
reds_on_vm_start(reds);
@ -4253,7 +4253,7 @@ SPICE_GNUC_VISIBLE void spice_server_vm_start(SpiceServer *reds)
SPICE_GNUC_VISIBLE void spice_server_vm_stop(SpiceServer *reds)
{
reds->vm_running = FALSE;
for (auto dev: reds->char_devices) {
for (const auto& dev: reds->char_devices) {
dev->stop();
}
reds_on_vm_stop(reds);