From 68a4eaedf1b6489bf37b903600d70735fe8deb9f Mon Sep 17 00:00:00 2001 From: Christophe Fergeau Date: Fri, 7 Apr 2017 18:24:03 +0200 Subject: [PATCH] Remove unneeded red_channel_client_is_blocked() call red_channel_client_msg_sent() calls red_channel_client_clear_sent_item() which will clear the rcc->priv->send_data.blocked flag. Later on, it contains a check for !red_channel_client_is_blocked(), which will always be true as nothing in between could have set it again. This commit removes this unneeded check. This check was already redundant when it was introduced in 9a62a9a809eaf0 Signed-off-by: Christophe Fergeau Acked-by: Frediano Ziglio --- server/red-channel-client.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/server/red-channel-client.c b/server/red-channel-client.c index f92f2e56..02dabdc4 100644 --- a/server/red-channel-client.c +++ b/server/red-channel-client.c @@ -652,8 +652,7 @@ static void red_channel_client_msg_sent(RedChannelClient *rcc) spice_assert(rcc->priv->send_data.header.data != NULL); red_channel_client_begin_send_message(rcc); } else { - if (!red_channel_client_is_blocked(rcc) - && g_queue_is_empty(&rcc->priv->pipe)) { + if (g_queue_is_empty(&rcc->priv->pipe)) { /* It is possible that the socket will become idle, so we may be able to test latency */ red_channel_client_restart_ping_timer(rcc); }