From 59be4f19c46cbeab0b8f405816b7bc4afe253187 Mon Sep 17 00:00:00 2001 From: Frediano Ziglio Date: Thu, 24 Aug 2017 21:43:18 +0100 Subject: [PATCH] red-client: Make sure MainChannelClient is freed as last MainChannelClient is used by other clients to store some data so should not disappear if other clients are still present. Keep a owning reference to it and release after RedClient is released. Signed-off-by: Frediano Ziglio --- server/red-client.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/server/red-client.c b/server/red-client.c index d73d0f8d..476f6f5b 100644 --- a/server/red-client.c +++ b/server/red-client.c @@ -106,6 +106,7 @@ red_client_finalize (GObject *object) { RedClient *self = RED_CLIENT(object); + g_clear_object(&self->mcc); spice_debug("release client=%p", self); pthread_mutex_destroy(&self->lock); @@ -313,7 +314,8 @@ MainChannelClient *red_client_get_main(RedClient *client) void red_client_set_main(RedClient *client, MainChannelClient *mcc) { - client->mcc = mcc; + spice_assert(client->mcc == NULL); + client->mcc = g_object_ref(mcc); } void red_client_semi_seamless_migrate_complete(RedClient *client)