pxcloud/spice
6
0
Fork 0
mirror of https://gitlab.uni-freiburg.de/opensourcevdi/spice synced 2026-08-08 16:48:06 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

red_get_image_data_flat: allocate mem after sanity check

Browse Source 
This patch prevents possible memory leak.

Found by coverity.

Signed-off-by: Uri Lublin <uril@redhat.com>
Acked-by: Frediano Ziglio <fziglio@redhat.com>
This commit is contained in:
Uri Lublin 2016-12-06 18:06:28 +02:00 committed by Frediano Ziglio
parent dad108edb1
commit 547f9f4387
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
server/red-parse-qxl.c
View File

@ -371,13 +371,16 @@ static SpiceChunks *red_get_image_data_flat(RedMemSlotInfo *slots, int group_id,
{
SpiceChunks *data;
int error;
unsigned long bitmap_virt;
data = spice_chunks_new(1);
data->data_size = size;
data->chunk[0].data = (void*)memslot_get_virt(slots, addr, size, group_id, &error);
bitmap_virt = memslot_get_virt(slots, addr, size, group_id, &error);
if (error) {
return 0;
}
data = spice_chunks_new(1);
data->data_size = size;
data->chunk[0].data = (void*)bitmap_virt;
data->chunk[0].len = size;
return data;
}