From 4f71d0cdb79d2f61da49d439a5b72e3ce0070313 Mon Sep 17 00:00:00 2001 From: Frediano Ziglio Date: Sat, 27 Jun 2020 13:02:57 +0100 Subject: [PATCH] Update spice-common submodule MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This brings in the following changes: Frediano Ziglio (18): snd_codec: Use better types for snd_codec_is_capable snd_codec: Use better type for function result snd_codec: Use better type for snd_codec_create mode backtrace: Do not attempt to compile if spice_backtrace is empty Avoid usage of GCC extension for __VA_ARGS__ where possible helper-fuzzer-demarshallers: Provide replacement for ftello for MSVC quic_tmpl: Remove unused bpc parameter ssl_verify: Do not check IP if we fail to resolve it proto: Add support for side mouse buttons quic: Constify a parameter quic: Fix typo in comment agent: Extend agent_check_message to support VDAgentMonitorsConfig extension quic: Check we have some data to start decoding quic image quic: Check image size in quic_decode_begin quic: Check RLE lengths quic: Avoid possible buffer overflow in find_bucket test-quic: Add fuzzer capabilities to the test test-quic: Add test cases for quic fuzzer Haochen Tong (2): pixman_utils: fix clang "unused functions" warning marshal: fix clang "missing field initializer" warning on generated files Marc-André Lureau (1): agent: fix vdagent monitor flag filtering Changes in sound.cpp are required due to improved types. In particular some security related changes are imported. Signed-off-by: Frediano Ziglio Acked-by: Uri Lublin --- server/sound.cpp | 6 +++--- subprojects/spice-common | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/server/sound.cpp b/server/sound.cpp index a7d7a11f..7c20e1da 100644 --- a/server/sound.cpp +++ b/server/sound.cpp @@ -340,8 +340,8 @@ bool RecordChannelClient::handle_message(uint16_t type, uint32_t size, void *mes mode_time = msg_mode->time; if (msg_mode->mode != SPICE_AUDIO_DATA_MODE_RAW) { if (snd_codec_is_capable((SpiceAudioDataMode) msg_mode->mode, channel->frequency)) { - if (snd_codec_create(&codec, msg_mode->mode, channel->frequency, - SND_CODEC_DECODE) == SND_CODEC_OK) { + if (snd_codec_create(&codec, (SpiceAudioDataMode) msg_mode->mode, + channel->frequency, SND_CODEC_DECODE) == SND_CODEC_OK) { mode = msg_mode->mode; } else { red_channel_warning(channel, "create decoder failed"); @@ -1004,7 +1004,7 @@ PlaybackChannelClient::PlaybackChannelClient(PlaybackChannel *channel, reds_config_get_playback_compression(channel->get_server()); int desired_mode = snd_desired_audio_mode(playback_compression, channel->frequency, client_can_opus); if (desired_mode != SPICE_AUDIO_DATA_MODE_RAW) { - if (snd_codec_create(&codec, desired_mode, channel->frequency, + if (snd_codec_create(&codec, (SpiceAudioDataMode) desired_mode, channel->frequency, SND_CODEC_ENCODE) == SND_CODEC_OK) { mode = desired_mode; } else { diff --git a/subprojects/spice-common b/subprojects/spice-common index a95ba61d..d589542e 160000 --- a/subprojects/spice-common +++ b/subprojects/spice-common @@ -1 +1 @@ -Subproject commit a95ba61d324e6e30e1c5b8e936176ff71af4d938 +Subproject commit d589542e0492888ac1b300200c7c6cb4eaf88cb0