pxcloud/spice
5
0
Fork 0
mirror of https://gitlab.uni-freiburg.de/opensourcevdi/spice synced 2026-01-06 21:22:55 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Use local variable to compute gradual score

Browse Source 
Due to aliasing using pointers lead to some sub-optimization.
Use local variable and then write them to output to improve performances.

Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
Acked-by: Julien Rope <jrope@redhat.com>
This commit is contained in:
Frediano Ziglio 2015-08-21 10:34:29 +01:00
parent 9e29b72461
commit 4c589e01fb
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
server/spice-bitmap-utils.tmpl.c
View File

@ -121,6 +121,8 @@ static void FNAME(compute_lines_gradual_score)(PIXEL *lines, int width, int num_
PIXEL *cur_pix = lines + width / 2;
PIXEL *bottom_pix;
PIXEL *last_line = lines + (num_lines - 1) * width;
int num_samples = 0;
double samples_sum_score = 0;
if ((width <= 1) || (num_lines <= 1)) {
*o_num_samples = 1;
@ -128,20 +130,18 @@ static void FNAME(compute_lines_gradual_score)(PIXEL *lines, int width, int num_
return;
}
*o_samples_sum_score = 0;
*o_num_samples = 0;
while (cur_pix < last_line) {
if ((cur_pix + 1 - lines) % width == 0) { // last pixel in the row
cur_pix--; // jump is bigger than 1 so we will not enter endless loop
}
bottom_pix = cur_pix + width;
(*o_samples_sum_score) += FNAME(pixels_square_score)(cur_pix, bottom_pix);
(*o_num_samples)++;
samples_sum_score += FNAME(pixels_square_score)(cur_pix, bottom_pix);
num_samples++;
cur_pix += jump;
}
(*o_num_samples) *= 3;
(*o_samples_sum_score) = samples_sum_score;
(*o_num_samples) = num_samples * 3;
}
#undef PIXEL