From 44624ed8bf774eb2c6b0fa1c097e87b3b9eef397 Mon Sep 17 00:00:00 2001 From: Uri Lublin Date: Sun, 16 Oct 2016 14:44:52 +0300 Subject: [PATCH] mjpeg_encoder_new: allocate memory after sanity check This patch prevents a leak in case the function returns early Found by coverity. Signed-off-by: Uri Lublin Acked-by: Frediano Ziglio --- server/mjpeg-encoder.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/server/mjpeg-encoder.c b/server/mjpeg-encoder.c index 1649516a..d95c645e 100644 --- a/server/mjpeg-encoder.c +++ b/server/mjpeg-encoder.c @@ -1372,10 +1372,11 @@ VideoEncoder *mjpeg_encoder_new(SpiceVideoCodecType codec_type, bitmap_ref_t bitmap_ref, bitmap_unref_t bitmap_unref) { - MJpegEncoder *encoder = spice_new0(MJpegEncoder, 1); + MJpegEncoder *encoder; spice_return_val_if_fail(codec_type == SPICE_VIDEO_CODEC_TYPE_MJPEG, NULL); + encoder = spice_new0(MJpegEncoder, 1); encoder->base.destroy = mjpeg_encoder_destroy; encoder->base.encode_frame = mjpeg_encoder_encode_frame; encoder->base.client_stream_report = mjpeg_encoder_client_stream_report;