From 41c042ca36f6d2a3fa6a0354befe59a784c1ca44 Mon Sep 17 00:00:00 2001 From: Frediano Ziglio Date: Wed, 16 Nov 2016 14:51:52 +0000 Subject: [PATCH] Avoid leaking file descriptor for statistics mmap memory area will remain even if the descriptor is closed. Signed-off-by: Frediano Ziglio Acked-by: Christophe Fergeau --- server/stat-file.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/server/stat-file.c b/server/stat-file.c index e9b42088..5f548697 100644 --- a/server/stat-file.c +++ b/server/stat-file.c @@ -46,9 +46,11 @@ void stat_file_init(RedStatFile *stat_file, unsigned int max_nodes) spice_error("statistics shm_open failed, %s", strerror(errno)); } if (ftruncate(fd, shm_size) == -1) { + close(fd); spice_error("statistics ftruncate failed, %s", strerror(errno)); } stat_file->stat = (SpiceStat *)mmap(NULL, shm_size, PROT_READ | PROT_WRITE, MAP_SHARED, fd, 0); + close(fd); if (stat_file->stat == (SpiceStat *)MAP_FAILED) { spice_error("statistics mmap failed, %s", strerror(errno)); }