pxcloud/spice
5
0
Fork 0
mirror of https://gitlab.uni-freiburg.de/opensourcevdi/spice synced 2025-12-29 17:07:15 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

red-channel-client: Remove push call where not necessary

Browse Source 
Now the push is done automatically when a PipeItem is added
(cfr commit 5c460de1a3
"worker: push data when clients can receive them"),
forcing a push cause only network fragmentation and is required only if
you are handling data in a polling loop (and thus, you are preventing
the default event loop from running).

Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
Acked-by: Christophe Fergeau <cfergeau@redhat.com>
This commit is contained in:
Frediano Ziglio 2017-08-29 09:03:33 +01:00
parent 02176e565c
commit 40c658f518
2 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
server/main-channel.c
View File

@ -81,7 +81,7 @@ void main_channel_push_mouse_mode(MainChannel *main_chan, SpiceMouseMode current
.is_client_mouse_allowed=is_client_mouse_allowed,
};
red_channel_pipes_new_add_push(RED_CHANNEL(main_chan),
red_channel_pipes_new_add(RED_CHANNEL(main_chan),
main_mouse_mode_item_new, &info);
}
@ -140,7 +140,7 @@ void main_channel_push_multi_media_time(MainChannel *main_chan, uint32_t time)
.time = time,
};
red_channel_pipes_new_add_push(RED_CHANNEL(main_chan),
red_channel_pipes_new_add(RED_CHANNEL(main_chan),
main_multi_media_time_item_new, &info);
}

2
server/red-channel-client.c
View File

@ -1590,7 +1590,6 @@ void red_channel_client_pipe_add_type(RedChannelClient *rcc, int pipe_item_type)
red_pipe_item_init(item, pipe_item_type);
red_channel_client_pipe_add(rcc, item);
red_channel_client_push(rcc);
}
void red_channel_client_pipe_add_empty_msg(RedChannelClient *rcc, int msg_type)
@ -1600,7 +1599,6 @@ void red_channel_client_pipe_add_empty_msg(RedChannelClient *rcc, int msg_type)
red_pipe_item_init(&item->base, RED_PIPE_ITEM_TYPE_EMPTY_MSG);
item->msg = msg_type;
red_channel_client_pipe_add(rcc, &item->base);
red_channel_client_push(rcc);
}
gboolean red_channel_client_pipe_is_empty(RedChannelClient *rcc)