pxcloud/spice
5
0
Fork 0
mirror of https://gitlab.uni-freiburg.de/opensourcevdi/spice synced 2025-12-26 22:48:19 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

spicec-x11: Fix unhandled exception: no window proc crash (rhbz#655836)

Browse Source 
When XIM + ibus is in use XIM creates an invisible window for its own
purposes, we sometimes get a _GTK_LOAD_ICONTHEMES ClientMessage event on
this window. Since this window was not explicitly created by spicec, it
does not have a Window Context (with the event handling function for the
window in question) set. This would cause spicec to throw an unhandled
exception and exit.

This patch replaces the exception throwing with silently ignoring
ClientMessage events on Windows without a Context and logging a warning
for other event types.
This commit is contained in:
Hans de Goede 2010-11-23 15:32:15 +01:00
parent 86e62813b3
commit 32d9486091
1 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
client/x11/platform.cpp
View File

@ -295,7 +295,15 @@ void XEventHandler::on_event()
}
if (XFindContext(&_x_display, event.xany.window, _win_proc_context, &proc_pointer)) {
THROW("no window proc");
/* When XIM + ibus is in use XIM creates an invisible window for
its own purposes, we sometimes get a _GTK_LOAD_ICONTHEMES
ClientMessage event on this window -> skip logging. */
if (event.type != ClientMessage) {
LOG_WARN(
"Event on window without a win proc, type: %d, window: %u",
event.type, (unsigned int)event.xany.window);
}
continue;
}
XUnlockDisplay(x_display);
((XPlatform::win_proc_t)proc_pointer)(event);