From 2d0d87277569e7e393cf896ea9372a2e3e6fbdd5 Mon Sep 17 00:00:00 2001 From: Uri Lublin Date: Thu, 16 Nov 2017 16:11:43 +0200 Subject: [PATCH] sound: fix params order when calling snd_desired_audio_mode Make sure client_can_celt is passed before client_can_opus The bug was present since introduction of opus in ce9b714137a767b81f2 Found by Coverity. Signed-off-by: Uri Lublin Acked-by: Victor Toso --- server/sound.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/server/sound.c b/server/sound.c index b1bfaaaa..68f3484d 100644 --- a/server/sound.c +++ b/server/sound.c @@ -1452,7 +1452,7 @@ void snd_set_playback_compression(bool on) bool client_can_opus = red_channel_client_test_remote_cap(rcc, SPICE_PLAYBACK_CAP_OPUS); int desired_mode = snd_desired_audio_mode(on, now->frequency, - client_can_opus, client_can_celt); + client_can_celt, client_can_opus); if (playback->mode != desired_mode) { playback->mode = desired_mode; snd_set_command(client, SND_PLAYBACK_MODE_MASK);