pxcloud/spice
5
0
Fork 0
mirror of https://gitlab.uni-freiburg.de/opensourcevdi/spice synced 2026-01-02 22:52:26 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

clang-tidy: use const reference for loop

Browse Source 
Found with performance-for-range-copy

Avoids unnecessary copying when the loop does not modify the variable.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
Acked-by: Frediano Ziglio <freddy77@gmail.com>
This commit is contained in:
Rosen Penev 2021-04-12 06:43:38 +01:00 committed by Frediano Ziglio
parent fc9ca6c71a
commit 24dfe33c06
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
server/reds.cpp
View File

@ -354,7 +354,7 @@ int reds_get_free_channel_id(RedsState *reds, uint32_t type)
// mark id used for the specific channel type
memset(used_ids, 0, sizeof(used_ids));
for (const auto channel: reds->channels) {
for (const auto &channel: reds->channels) {
if (channel->type() == type && channel->id() < SPICE_N_ELEMENTS(used_ids)) {
used_ids[channel->id()] = true;
}
@ -599,7 +599,7 @@ static void reds_update_mouse_mode(RedsState *reds)
int qxl_count = reds->qxl_instances.size();
int display_channel_count = 0;
for (const auto channel: reds->channels) {
for (const auto &channel: reds->channels) {
if (channel->type() == SPICE_CHANNEL_DISPLAY) {
++display_channel_count;
}
@ -972,7 +972,7 @@ static void reds_fill_channels(RedsState *reds, SpiceMsgChannels *channels_info)
{
int used_channels = 0;
for (const auto channel: reds->channels) {
for (const auto &channel: reds->channels) {
if (reds->clients.size() > 1 &&
!channel_supports_multiple_clients(channel.get())) {
continue;