pxcloud/spice
5
0
Fork 0
mirror of https://gitlab.uni-freiburg.de/opensourcevdi/spice synced 2025-12-26 14:41:25 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

test-display-base: Fix warning message avoidance

Browse Source 
test_new function attempts to detect attempts to listen to tcp ports
already in listening state detecting some messages during
spice_server_init. However the check is wrong (broken in recent
34a44d3e94 "test-display-base: Avoid spurious errors due to listen
failures") and incomplete (missing message).

To better test this conditions put some of the ports in listening
state (like with a "nc -l 5912 & nc -l 5913 &" command) and run
tests in parallel (like with a "make check -j" command).

Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
Acked-by: Eduardo Lima (Etrunko) <etrunko@redhat.com>
This commit is contained in:
Frediano Ziglio 2018-11-10 10:56:07 +00:00
parent 91b15b6de3
commit 1bad26b663
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
server/tests/test-display-base.c
View File

@ -905,8 +905,9 @@ static gboolean ignore_in_use_failures(const gchar *log_domain,
if ((log_level & G_LOG_LEVEL_WARNING) == 0) {
return true;
}
if (strstr(message, "reds_init_socket: binding socket to ") == NULL || // bind failure
strstr(message, "reds_init_socket: listen: ") == NULL) { // listen failure
if (strstr(message, "reds_init_socket: binding socket to ") == NULL && // bind failure
strstr(message, "reds_init_socket: listen: ") == NULL && // listen failure
strstr(message, "Failed to open SPICE sockets") == NULL) { // global
g_print("XXX [%s]\n", message);
return true;
}