mirror of
https://gitlab.uni-freiburg.de/opensourcevdi/spice-protocol
synced 2026-08-10 19:24:43 +00:00
f6e4cb65da
The SpiceStat structure can be 20 or 24 bytes depending on alignment. Being a memory mapped structure potentially used with lockless access, it is not good to have it unaligned. The only tool that we know of that reads this memory mapped file (reds_stats) is able to detect if the structure is either 20 or 24 bytes and act accordingly so changing this structure won't affect the behaviour (unless you have an old tool but as they are usually packaged together this is quite improbable). This will also help on Windows as in that system it is not possible for reds_stats to implement the same discovery trick implemented on Linux. On Windows it is not possible to read the size of the file mapping (on Windows to implement shared memory you can use a file mapping not associated to a file). The structure will change layout only on 32-bit architectures which is not recommended nowadays (the 64-bit platforms that we support align 64-bit integers to 64 bits). Signed-off-by: Frediano Ziglio <fziglio@redhat.com> Acked-by: Christophe Fergeau <cfergeau@redhat.com> |
||
|---|---|---|
| .. | ||
| barrier.h | ||
| controller_prot.h | ||
| end-packed.h | ||
| enums.h | ||
| foreign_menu_prot.h | ||
| ipc_ring.h | ||
| macros.h | ||
| Makefile.am | ||
| meson.build | ||
| protocol.h | ||
| qxl_dev.h | ||
| qxl_windows.h | ||
| start-packed.h | ||
| stats.h | ||
| stream-device.h | ||
| types.h | ||
| vd_agent.h | ||
| vdi_dev.h | ||