mirror of
https://gitlab.uni-freiburg.de/opensourcevdi/spice-protocol
synced 2025-12-27 15:08:16 +00:00
beda5ec7a6
This avoids compilers detect misaligned access which can lead to warnings. In QEMU the structure is allocated at the beginning of a 4Kb page, in Xspice is allocated with a calloc, so the structure will end up 4 bytes aligned as well with these users. We are not aware of other users of QXLRam, but if there was, it's likely the struct would be at least naturally aligned, so this change should not impact anyone. Aligning to 4 bytes maintains the size of the structure unchanged avoiding possible ABI changes. clang currently generates an invalid function call if a misaligned 4 byte atomic operation is detected. This fixes https://bugzilla.redhat.com/show_bug.cgi?id=1565766 Signed-off-by: Frediano Ziglio <fziglio@redhat.com> Acked-by: Christophe Fergeau <cfergeau@redhat.com>
67 lines
2.3 KiB
C
67 lines
2.3 KiB
C
/* -*- Mode: C; tab-width: 4; c-basic-offset: 4; indent-tabs-mode: nil -*- */
|
|
/*
|
|
Copyright (C) 2009 Red Hat, Inc.
|
|
|
|
Redistribution and use in source and binary forms, with or without
|
|
modification, are permitted provided that the following conditions are
|
|
met:
|
|
|
|
* Redistributions of source code must retain the above copyright
|
|
notice, this list of conditions and the following disclaimer.
|
|
* Redistributions in binary form must reproduce the above copyright
|
|
notice, this list of conditions and the following disclaimer in
|
|
the documentation and/or other materials provided with the
|
|
distribution.
|
|
* Neither the name of the copyright holder nor the names of its
|
|
contributors may be used to endorse or promote products derived
|
|
from this software without specific prior written permission.
|
|
|
|
THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDER AND CONTRIBUTORS "AS
|
|
IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED
|
|
TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A
|
|
PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
|
|
HOLDER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
|
|
SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
|
|
LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
|
|
DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
|
|
THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
|
|
(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
|
|
OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
|
|
*/
|
|
|
|
/* Ideally this should all have been macros in a common headers, but
|
|
* its not possible to put pragmas into header files, so we have
|
|
* to use include magic.
|
|
*
|
|
* Use it like this:
|
|
*
|
|
* #include <spice/start-packed.h>
|
|
*
|
|
* typedef struct SPICE_ATTR_PACKED {
|
|
* ...
|
|
* } Type;
|
|
*
|
|
* #include <spice/end-packed.h>
|
|
*
|
|
*/
|
|
|
|
#ifdef __GNUC__
|
|
|
|
#define SPICE_ATTR_PACKED __attribute__ ((__packed__))
|
|
#define SPICE_ATTR_ALIGNED(n) __attribute__ ((__aligned__ (n)))
|
|
|
|
#ifdef __MINGW32__
|
|
#pragma pack(push,1)
|
|
#endif
|
|
|
|
#else
|
|
|
|
#pragma pack(push)
|
|
#pragma pack(1)
|
|
#define SPICE_ATTR_PACKED
|
|
#define SPICE_ATTR_ALIGNED(n) __declspec (align (n))
|
|
#pragma warning(disable:4200)
|
|
#pragma warning(disable:4103)
|
|
|
|
#endif
|