pxcloud/spice-protocol
6
0
Fork 0
mirror of https://gitlab.uni-freiburg.de/opensourcevdi/spice-protocol synced 2026-08-09 22:00:56 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

stream-device: Specify how padding shoud be inside new structures

Browse Source 
Depending on how structures are initialised in the code is
possible that implicit padding bytes are not initialised
causing possible information leaks as the entire structure
with all padding is sent through device/network.

Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
Acked-by: Christophe de Dinechin <dinechin@redhat.com>
This commit is contained in:
Frediano Ziglio 2018-02-23 10:11:12 +00:00
parent bd279b1fc1
commit 235ac17349
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
spice/stream-device.h
View File

@ -48,6 +48,8 @@
* containing integers up to 64 bit.
* All numbers are in little endian format.
*
* For security reasons structures should not contain implicit paddings.
*
* The protocol can be defined by these states:
* - Initial. Device just opened. Guest should wait
* for a message from the host;