Commit Graph

7 Commits

Author SHA1 Message Date
Pavel Grunt
b708989b12 util: Remove unused GError parameter
The parameter is removed from functions:
 get_line
 spice_convert_newlines
 spice_unix2dos
 spice_dos2unix

It was introduced in 75f1ea3ee9
but never used

Acked-by: Marc-André Lureau <mlureau@redhat.com>
Acked-by: Christophe Fergeau <cfergeau@redhat.com>
2016-09-02 13:14:17 +02:00
Marc-André Lureau
3c6b4ae867 build-sys: fix 'Only <spice-client.h> can be included directly' warning
Tests should be allowed to include directly private headers. Set
__SPICE_CLIENT_H_INSIDE__ where necessary or include spice-client.h
where possible.

Signed-off-by: Marc-André Lureau <marcandre.lureau@gmail.com>
Acked-by: Fabiano Fidêncio <fidencio@redhat.com>
2016-03-15 17:11:18 +01:00
Pavel Grunt
457d556c00 Fix -Wsign-compare 2014-09-18 13:21:58 +02:00
Ryan Lortie
e189c97694 utils tests: fix sign comparison problem
This test compares a guint8 and a gchar with '==' which fails when comparing
240 to -16, even though these are the same byte value.  Add an explicit
'guchar' cast to correct the problem.

https://bugs.freedesktop.org/show_bug.cgi?id=74754
2014-02-10 14:38:57 +01:00
Marc-André Lureau
0eaf492097 test: fix a few compiler warnings
util.c: In function 'test_set_bit':
util.c:131:13: warning: pointer targets in initialization differ in signedness [-Wpointer-sign]
2014-02-07 13:55:57 +01:00
Alon Levy
11ddba4b09 channel-cursor: mono cursors edge highlighting
Fix 998529, mono (invert) cursors not visible on a black background, by doing
simple edge detection on the cursor (this is done once when the cursor
is changed and then cached, cursors are 32x32 generally) and thus having
a cursor with contrast on both dark and light backgrounds.

When (if) GDK gets invert cursor support (wayland?) then we can just use
the cursor as is. Until then X doesn't provide any way I see of solving
this otherwise. The end result was tested with the I beam cursor that
the original bug was referring to (run putty on a windows 7 vm) and
looks ok to me.

Moving the core function to spice-util for testing.
2013-10-20 00:31:32 +03:00
Marc-André Lureau
a5f9eb7644 tests: add some dos2unix tests
This is probably not exhaustive enough, but better than nothing.
2013-08-24 17:50:20 +02:00