From cbf9da900caa2ac9be55eabd9f20ed4f23c7cee2 Mon Sep 17 00:00:00 2001 From: Christophe Fergeau Date: Wed, 27 Jul 2016 12:50:41 +0200 Subject: [PATCH] vmc: Fix leak in spice_vmc_output_stream_write_finish() MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit We own a reference on the GAsyncResult returned by g_task_propage_pointer() so we have to g_object_unref() it when we no longer need it. Acked-by: Fabiano FidĂȘncio --- src/vmcstream.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/vmcstream.c b/src/vmcstream.c index ffb1ba4..09a296b 100644 --- a/src/vmcstream.c +++ b/src/vmcstream.c @@ -399,9 +399,13 @@ spice_vmc_output_stream_write_finish(GOutputStream *stream, { SpiceVmcOutputStream *self = SPICE_VMC_OUTPUT_STREAM(stream); GAsyncResult *res = g_task_propagate_pointer(G_TASK(simple), error); + gssize bytes_written; SPICE_DEBUG("spicevmc write finish"); - return spice_vmc_write_finish(self->channel, res, error); + bytes_written = spice_vmc_write_finish(self->channel, res, error); + g_object_unref(res); + + return bytes_written; } static void