From 2bb8e732fd22d63b08d16ee2caf5e58425de74b7 Mon Sep 17 00:00:00 2001 From: Victor Toso Date: Tue, 17 May 2016 22:22:36 +0200 Subject: [PATCH] file-xfer: inform agent of errors only when task finished No need to inform of a problem under spice_file_transfer_task_completed() as the task will be finalized and we can send the error to the agent there. This change is related to split SpiceFileTransferTask from channel-main. Acked-by: Jonathon Jongsma --- src/channel-main.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/src/channel-main.c b/src/channel-main.c index 3396bb1..2456e3a 100644 --- a/src/channel-main.c +++ b/src/channel-main.c @@ -2991,16 +2991,6 @@ static void spice_file_transfer_task_completed(SpiceFileTransferTask *self, self->error = error; } - if (self->error) { - VDAgentFileXferStatusMessage msg = { - .id = self->id, - .result = self->error->code == G_IO_ERROR_CANCELLED ? - VD_AGENT_FILE_XFER_STATUS_CANCELLED : VD_AGENT_FILE_XFER_STATUS_ERROR, - }; - agent_msg_queue_many(self->channel, VD_AGENT_FILE_XFER_STATUS, - &msg, sizeof(msg), NULL); - } - if (self->pending) { /* Complete but pending is okay only if error is set */ if (self->error == NULL) {