mirror of
https://gitlab.uni-freiburg.de/opensourcevdi/spice-common
synced 2025-12-26 14:18:36 +00:00
4951c71553
This commit adds a SPICE_UNREACHABLE macro (courtesy of Frediano)
so that gcc does not think that code control can go past
spice_return_{val_,}if_fail(), spice_critical() and spice_error()
This avoids this kind of warnings:
fallthrough.c:
#include "log.h"
int main(int argc, char **argv)
{
switch(argc) {
case 1:
spice_critical("foo");
default:
return 0;
}
}
$ gcc -c $(pkg-config --cflags --libs glib-2.0 spice-protocol)
-I common -Wimplicit-fallthrough=5 ./fallthrough.c
In file included from ./fallthrough.c:1:
./fallthrough.c: In function 'main':
common/log.h:73:5: warning: this statement may fall through [-Wimplicit-fallthrough=]
73 | spice_log(G_LOG_LEVEL_CRITICAL, SPICE_STRLOC, __FUNCTION__, "" format, ## __VA_ARGS__); \
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
./fallthrough.c:8:25: note: in expansion of macro 'spice_critical'
8 | spice_critical("foo");
| ^~~~~~~~~~~~~~
./fallthrough.c:9:17: note: here
9 | default:
| ^~~~~~~
Signed-off-by: Christophe Fergeau <cfergeau@redhat.com>
Acked-by: Frediano Ziglio <fziglio@redhat.com>
67 lines
2.5 KiB
C
67 lines
2.5 KiB
C
/* -*- Mode: C; c-basic-offset: 4; indent-tabs-mode: nil -*- */
|
|
/*
|
|
Copyright (C) 2009 Red Hat, Inc.
|
|
|
|
This library is free software; you can redistribute it and/or
|
|
modify it under the terms of the GNU Lesser General Public
|
|
License as published by the Free Software Foundation; either
|
|
version 2.1 of the License, or (at your option) any later version.
|
|
|
|
This library is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
Lesser General Public License for more details.
|
|
|
|
You should have received a copy of the GNU Lesser General Public
|
|
License along with this library; if not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
#ifndef H_SPICE_COMMON_MACROS
|
|
#define H_SPICE_COMMON_MACROS
|
|
|
|
#include "verify.h"
|
|
|
|
#if __GNUC__ > 2 || (__GNUC__ == 2 && __GNUC_MINOR__ >= 5)
|
|
#define SPICE_ATTR_NORETURN \
|
|
__attribute__((noreturn))
|
|
#define SPICE_ATTR_PRINTF(a,b) \
|
|
__attribute__((format(printf,a,b)))
|
|
#else
|
|
#define SPICE_ATTR_NORETURN
|
|
#define SPICE_ATTR_PRINTF
|
|
#endif /* __GNUC__ */
|
|
|
|
#ifdef __GNUC__
|
|
#define SPICE_CONSTRUCTOR_FUNC(func_name) \
|
|
static void __attribute__((constructor)) func_name(void)
|
|
#define SPICE_DESTRUCTOR_FUNC(func_name) \
|
|
static void __attribute__((destructor)) func_name(void)
|
|
#elif defined(_MSC_VER)
|
|
#define SPICE_CONSTRUCTOR_FUNC(func_name) \
|
|
static void func_name(void); \
|
|
static int func_name ## _wrapper(void) { func_name(); return 0; } \
|
|
__pragma(section(".CRT$XCU",read)) \
|
|
__declspec(allocate(".CRT$XCU")) static int (* _array ## func_name)(void) = func_name ## _wrapper; \
|
|
static void func_name(void)
|
|
#define SPICE_DESTRUCTOR_FUNC(func_name) \
|
|
static void func_name(void); \
|
|
static int func_name ## _wrapper(void) { func_name(); return 0; } \
|
|
__pragma(section(".CRT$XPU",read)) \
|
|
__declspec(allocate(".CRT$XPU")) static int (* _array ## func_name)(void) = func_name ## _wrapper; \
|
|
static void func_name(void)
|
|
#else
|
|
#error Please implement SPICE_CONSTRUCTOR_FUNC and SPICE_DESTRUCTOR_FUNC for this compiler
|
|
#endif
|
|
|
|
#define SPICE_VERIFY(cond) verify_expr(cond, (void)1)
|
|
|
|
#if __GNUC__ > 4 || (__GNUC__ == 4 && __GNUC_MINOR__ >= 5)
|
|
#define SPICE_UNREACHABLE __builtin_unreachable()
|
|
#elif defined(_MSC_VER)
|
|
#define SPICE_UNREACHABLE __assume(0)
|
|
#else
|
|
#define SPICE_UNREACHABLE for(;;) continue
|
|
#endif
|
|
|
|
#endif // H_SPICE_COMMON_MACROS
|