pxcloud/spice-common
5
0
Fork 0
mirror of https://gitlab.uni-freiburg.de/opensourcevdi/spice-common synced 2026-01-09 22:25:28 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

log: Do not check impossible function return

Browse Source 
spice_log_level_to_glib never returns 0 so don't check
for this value.

Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
Acked-by: Christophe Fergeau <cfergeau@redhat.com>
This commit is contained in:
Frediano Ziglio 2017-05-31 08:47:15 +01:00
parent 36fd7325e5
commit f4a4d52702
1 changed files with 5 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
common/log.c
View File

@ -104,14 +104,12 @@ static void spice_log_set_abort_level(void)
g_warning("Setting SPICE_ABORT_LEVEL is deprecated, use G_DEBUG instead");
abort_level = atoi(abort_str);
glib_abort_level = spice_log_level_to_glib(abort_level);
if (glib_abort_level != 0) {
unsigned int fatal_mask = G_LOG_FATAL_MASK;
while (glib_abort_level >= G_LOG_LEVEL_ERROR) {
fatal_mask |= glib_abort_level;
glib_abort_level >>= 1;
}
g_log_set_fatal_mask(SPICE_LOG_DOMAIN, fatal_mask);
unsigned int fatal_mask = G_LOG_FATAL_MASK;
while (glib_abort_level >= G_LOG_LEVEL_ERROR) {
fatal_mask |= glib_abort_level;
glib_abort_level >>= 1;
}
g_log_set_fatal_mask(SPICE_LOG_DOMAIN, fatal_mask);
} else {
abort_level = SPICE_ABORT_LEVEL_DEFAULT;
}
@ -157,8 +155,6 @@ static void spice_logv(const char *log_domain,
{
GString *log_msg;
g_return_if_fail(spice_log_level_to_glib(log_level) != 0);
log_msg = g_string_new(NULL);
if (strloc && function) {
g_string_append_printf(log_msg, "%s:%s: ", strloc, function);