pxcloud/spice-common
6
0
Fork 0
mirror of https://gitlab.uni-freiburg.de/opensourcevdi/spice-common synced 2026-08-06 20:37:02 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

quic: Check RLE lengths

Browse Source 
Avoid buffer overflows decoding images. On compression we compute
lengths till end of line so it won't cause regressions.
Proved by fuzzing the code.

Signed-off-by: Frediano Ziglio <freddy77@gmail.com>
Acked-by: Uri Lublin <uril@redhat.com>
This commit is contained in:
Frediano Ziglio 2020-04-29 15:11:38 +01:00
parent 404d74782c
commit ef1b6ff7b8
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
common/quic_tmpl.c
View File

@ -563,7 +563,11 @@ static void FNAME_DECL(uncompress_row_seg)(const PIXEL * const prev_row,
do_run:
state->waitcnt = stopidx - i;
run_index = i;
run_end = i + decode_state_run(encoder, state);
run_end = decode_state_run(encoder, state);
if (run_end < 0 || run_end > (end - i)) {
encoder->usr->error(encoder->usr, "wrong RLE\n");
}
run_end += i;
for (; i < run_end; i++) {
UNCOMPRESS_PIX_START(&cur_row[i]);