pxcloud/spice-common
5
0
Fork 0
mirror of https://gitlab.uni-freiburg.de/opensourcevdi/spice-common synced 2025-12-31 19:45:43 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

canvas: Remove possible leak on LZ decompression failure

Browse Source 
longjmp can happen in different places, even after the palette
is allocated so we need to free it if it got allocated.

Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
Acked-by: Uri Lublin <uril@redhat.com>
This commit is contained in:
Frediano Ziglio 2017-12-22 18:42:41 +00:00
parent d11df6b66b
commit 29eff61cf8
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
common/canvas_base.c
View File

@ -783,15 +783,17 @@ static pixman_image_t *canvas_get_lz(CanvasBase *canvas, SpiceImage *image,
int top_down;
int stride_encoded;
int stride;
int free_palette;
int free_palette = FALSE;
if (setjmp(lz_data->jmp_env)) {
if (free_palette) {
free(palette);
}
free(decomp_buf);
spice_warning("%s", lz_data->message_buf);
return NULL;
}
free_palette = FALSE;
if (image->descriptor.type == SPICE_IMAGE_TYPE_LZ_RGB) {
spice_return_val_if_fail(image->u.lz_rgb.data->num_chunks == 1, NULL); /* TODO: Handle chunks */
comp_buf = image->u.lz_rgb.data->chunk[0].data;