pxcloud/spice-common
5
0
Fork 0
mirror of https://gitlab.uni-freiburg.de/opensourcevdi/spice-common synced 2026-02-05 06:11:02 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix some integer range checks which always evaluate false

Browse Source 
There are some integer range checks which always evaluate false
due to use of unsigned integer types. One of these would prevent
detection of encoding errors from celt. The others are simply
no-ops.

* common/pixman_utils.c: SpiceROP is an enum & thus unsigned
This commit is contained in:
Daniel P. Berrange 2012-02-10 14:05:27 +00:00 committed by Marc-André Lureau
parent d8dda8213b
commit 161e37ea9f
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
pixman_utils.c
View File

@ -304,7 +304,7 @@ void spice_pixman_fill_rect_rop(pixman_image_t *dest,
spice_assert(height > 0);
spice_assert(x + width <= pixman_image_get_width(dest));
spice_assert(y + height <= pixman_image_get_height(dest));
spice_assert(rop >= 0 && rop < 16);
spice_assert(rop < 16);
if (depth == 8) {
solid_rop_8_func_t rop_func = solid_rops_8[rop];
@ -455,7 +455,7 @@ void spice_pixman_tile_rect_rop(pixman_image_t *dest,
spice_assert(height > 0);
spice_assert(x + width <= pixman_image_get_width(dest));
spice_assert(y + height <= pixman_image_get_height(dest));
spice_assert(rop >= 0 && rop < 16);
spice_assert(rop < 16);
spice_assert(depth == spice_pixman_image_get_bpp(tile));
tile_start_x = (x - offset_x) % tile_width;