a4bdb1649a
This PR adds Node24 support **Node/V8 changes:** - Move to new V8 syntax for some constructs (e.g. Cast<>) - Tracked down two issues which caused the read-only snapshot to be different across platforms: - in `read-only-serializer:258` the "live" pointer gets overwritten by the encoded slot (EncodedTagged). If V8_COMPRESS_POINTERS is not enabled, EncodedTagged is 4 bytes, but the live pointer is 8 bytes. memcpy() only copies EncodeTagged leaving 4bytes of "garbage" (=previous upper pointer half) which is semi-random per run - fixed this by clearing the whole value first - the CSA_HOLE_SECURITY_CHECK macro somehow leaves a string with a platform-dependent filename in the readonly heap as a constant, replaced that with "placeholder" - add PKG_TRACE_READONLY_HEAP blocks for debugging further snapshot issues Those fixes partially fix the sourceless cross-build issues introduced in Node 22 - For my test builds linux/linuxstatic/alpine/win on x64 are now compatible again. The heap contents on macos builds and other arm64 is wildly different, not sure why. I don't think this kind of compatibility is a goal for the V8 snapshot implementation in general. (This affects Node SEA as well, but SEA always has the source to fall back onto, which incurs a small performance hit) **Build Changes:** - Update linux/linuxcross build to use gcc 12 (required for Node 24) - For aloine/linuxstatic: Node 24 doesn't build on the muslcc image used previously, the image is unmaintained (although the toolchain builder isn't, we could build our own image) - Moved alpine/linuxstatic to native Alpine x64/arm64 toolchains, which seems to work quite well - Some minor upgrades to the Windows build, but had to enable `full-icu` for now because the ICU code gen step crashes with `small-icu` on the GH action build runners (not on my Windows test machine though) - Moved the macos build to macos 14 which is now required for Node 24 - x64 is now cross-built from arm64 because GH doesn't offer free macos14 x64 build workers - Removed all builds for Node 18 and older - **Notes:** - Needs more testing, I did some basic testing for x64 builds as well as macos/arm64 - I added a backport of the snapshot-determinism fixes to the latest Node 22 patch
48 lines
1.3 KiB
Docker
48 lines
1.3 KiB
Docker
FROM ubuntu:noble AS build
|
|
|
|
USER root:root
|
|
WORKDIR /root/pkg-fetch/
|
|
ENV DEBIAN_FRONTEND=noninteractive
|
|
|
|
RUN apt-get update
|
|
RUN apt-get install -y curl software-properties-common ca-certificates gnupg
|
|
|
|
# Install Node.js 20
|
|
RUN curl -fsSL https://deb.nodesource.com/setup_20.x | bash - && \
|
|
apt-get install -y nodejs
|
|
|
|
RUN apt-get install -y binutils g++ git make patch python3 python3-setuptools
|
|
|
|
ARG TARGET_TOOLCHAIN_ARCH
|
|
|
|
RUN [ `uname -m` = ${TARGET_TOOLCHAIN_ARCH} ] || \
|
|
apt-get install -y binutils-${TARGET_TOOLCHAIN_ARCH}-linux-gnu g++-${TARGET_TOOLCHAIN_ARCH}-linux-gnu
|
|
|
|
ENV CC=${TARGET_TOOLCHAIN_ARCH}-linux-gnu-gcc
|
|
ENV CXX=${TARGET_TOOLCHAIN_ARCH}-linux-gnu-g++
|
|
ENV AR=${TARGET_TOOLCHAIN_ARCH}-linux-gnu-ar
|
|
ENV NM=${TARGET_TOOLCHAIN_ARCH}-linux-gnu-nm
|
|
ENV RANLIB=${TARGET_TOOLCHAIN_ARCH}-linux-gnu-ranlib
|
|
ENV READELF=${TARGET_TOOLCHAIN_ARCH}-linux-gnu-readelf
|
|
ENV STRIP=${TARGET_TOOLCHAIN_ARCH}-linux-gnu-strip
|
|
ENV CC_host=gcc
|
|
ENV CXX_host=g++
|
|
ENV AR_host=ar
|
|
ENV NM_host=nm
|
|
ENV RANLIB_host=ranlib
|
|
ENV READELF_host=readelf
|
|
|
|
RUN npm install -g yarn
|
|
|
|
COPY . ./
|
|
|
|
RUN yarn install --ignore-engines
|
|
|
|
ARG PKG_FETCH_OPTION_a
|
|
ARG PKG_FETCH_OPTION_n
|
|
|
|
RUN yarn start --arch $PKG_FETCH_OPTION_a --node-range $PKG_FETCH_OPTION_n --output dist
|
|
|
|
FROM scratch
|
|
COPY --from=build /root/pkg-fetch/dist /
|