pxcloud/pkg-fetch
6
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

build: don't strip global symbols of macOS binaries

Browse Source 
Bug: vercel/pkg#1155
This commit is contained in:
Jesse Chan 2021-05-10 23:34:44 +08:00
parent a062bb42f5
commit 5d2bc3bb24
1 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
lib/build.ts
View File

@ -201,9 +201,14 @@ async function compileOnUnix(
const output = path.join(nodePath, 'out/Release/node'); const output = path.join(nodePath, 'out/Release/node');
await spawn(process.env.STRIP || 'strip', [output], { await spawn(
stdio: 'inherit', process.env.STRIP || 'strip',
}); // global symbols are required for native bindings on macOS
[...(targetPlatform === 'macos' ? ['-x'] : []), output],
{
stdio: 'inherit',
}
);
if (targetPlatform === 'macos') { if (targetPlatform === 'macos') {
// Newer versions of Apple Clang automatically ad-hoc sign the compiled executable. // Newer versions of Apple Clang automatically ad-hoc sign the compiled executable.