pxcloud/pkg-fetch
6
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

bugfix

Browse Source
This commit is contained in:
Igor Klopov 2016-08-12 20:07:31 +03:00
parent 3da49f160a
commit 28abf5fa75
2 changed files with 17 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lib/upload.js
View File

@ -1,4 +1,5 @@
import { createRelease, getRelease, uploadAsset } from './github.js';
import assert from 'assert';
function uniqueName (remote, names) {
if (names.indexOf(remote) < 0) return remote;
@ -15,7 +16,10 @@ export default async function upload (local, remote, version) {
const tag = `v${version}`;
let release = await getRelease(tag);
if (!release) release = await createRelease(tag);
const names = release.assets.map(({ name }) => name);
const names = release.assets.map(({ name }) => {
assert(name);
return name;
});
const name = uniqueName(remote, names);
await uploadAsset(local, release, name);
}

20
test/build-and-upload.js
View File

@ -63,12 +63,12 @@ require('../lib/github.js').createRelease = function (tag) {
require('../lib/github.js').uploadAsset = function (local, release, name) {
assert(local === lastLocal); // test it here. too flaky to push to actions
actions.push([ 'uploadAsset', JSON.stringify(release), name ].join(' '));
assets.push(name);
assets.push({ name });
};
test(async () => {
await main();
assert.deepEqual(actions, [
const mustBe = [
'git clone https://github.com/nodejs/node node {"stdio":"inherit","cwd":"../temp"}',
'git reset --hard v0.12.15 {"stdio":"inherit","cwd":"../temp/node"}',
'patch -p1 -i ../patches/backport.R00000.patch {"stdio":"inherit","cwd":"../temp/node"}',
@ -114,7 +114,7 @@ test(async () => {
'copyFile ../temp/node/out/Release/node',
'getRelease v7.8.9',
'createRelease v7.8.9',
'uploadAsset {"upload_url":"https://example.com/assets{?name,label}","assets":["v0.12.15-linux-x64"]} v0.12.15-linux-x86',
'uploadAsset {"upload_url":"https://example.com/assets{?name,label}","assets":[{"name":"v0.12.15-linux-x64"}]} v0.12.15-linux-x86',
'git clone https://github.com/nodejs/node node {"stdio":"inherit","cwd":"../temp"}',
'git reset --hard v4.4.7 {"stdio":"inherit","cwd":"../temp/node"}',
'patch -p1 -i ../patches/backport.R32768.v8=4.5.patch {"stdio":"inherit","cwd":"../temp/node"}',
@ -124,7 +124,7 @@ test(async () => {
'copyFile ../temp/node/out/Release/node',
'getRelease v7.8.9',
'createRelease v7.8.9',
'uploadAsset {"upload_url":"https://example.com/assets{?name,label}","assets":["v0.12.15-linux-x64","v0.12.15-linux-x86"]} v4.4.7-linux-x64',
'uploadAsset {"upload_url":"https://example.com/assets{?name,label}","assets":[{"name":"v0.12.15-linux-x64"},{"name":"v0.12.15-linux-x86"}]} v4.4.7-linux-x64',
'git clone https://github.com/nodejs/node node {"stdio":"inherit","cwd":"../temp"}',
'git reset --hard v4.4.7 {"stdio":"inherit","cwd":"../temp/node"}',
'patch -p1 -i ../patches/backport.R32768.v8=4.5.patch {"stdio":"inherit","cwd":"../temp/node"}',
@ -134,7 +134,7 @@ test(async () => {
'copyFile ../temp/node/out/Release/node',
'getRelease v7.8.9',
'createRelease v7.8.9',
'uploadAsset {"upload_url":"https://example.com/assets{?name,label}","assets":["v0.12.15-linux-x64","v0.12.15-linux-x86","v4.4.7-linux-x64"]} v4.4.7-linux-x86',
'uploadAsset {"upload_url":"https://example.com/assets{?name,label}","assets":[{"name":"v0.12.15-linux-x64"},{"name":"v0.12.15-linux-x86"},{"name":"v4.4.7-linux-x64"}]} v4.4.7-linux-x86',
'git clone https://github.com/nodejs/node node {"stdio":"inherit","cwd":"../temp"}',
'git reset --hard v6.3.1 {"stdio":"inherit","cwd":"../temp/node"}',
'patch -p1 -i ../patches/node.v6.3.1.patch {"stdio":"inherit","cwd":"../temp/node"}',
@ -143,7 +143,7 @@ test(async () => {
'copyFile ../temp/node/out/Release/node',
'getRelease v7.8.9',
'createRelease v7.8.9',
'uploadAsset {"upload_url":"https://example.com/assets{?name,label}","assets":["v0.12.15-linux-x64","v0.12.15-linux-x86","v4.4.7-linux-x64","v4.4.7-linux-x86"]} v6.3.1-linux-x64',
'uploadAsset {"upload_url":"https://example.com/assets{?name,label}","assets":[{"name":"v0.12.15-linux-x64"},{"name":"v0.12.15-linux-x86"},{"name":"v4.4.7-linux-x64"},{"name":"v4.4.7-linux-x86"}]} v6.3.1-linux-x64',
'git clone https://github.com/nodejs/node node {"stdio":"inherit","cwd":"../temp"}',
'git reset --hard v6.3.1 {"stdio":"inherit","cwd":"../temp/node"}',
'patch -p1 -i ../patches/node.v6.3.1.patch {"stdio":"inherit","cwd":"../temp/node"}',
@ -152,6 +152,10 @@ test(async () => {
'copyFile ../temp/node/out/Release/node',
'getRelease v7.8.9',
'createRelease v7.8.9',
'uploadAsset {"upload_url":"https://example.com/assets{?name,label}","assets":["v0.12.15-linux-x64","v0.12.15-linux-x86","v4.4.7-linux-x64","v4.4.7-linux-x86","v6.3.1-linux-x64"]} v6.3.1-linux-x86'
]);
'uploadAsset {"upload_url":"https://example.com/assets{?name,label}","assets":[{"name":"v0.12.15-linux-x64"},{"name":"v0.12.15-linux-x86"},{"name":"v4.4.7-linux-x64"},{"name":"v4.4.7-linux-x86"},{"name":"v6.3.1-linux-x64"}]} v6.3.1-linux-x86'
];
assert.equal(actions.length, mustBe.length);
for (let i = 0; i < actions.length; i += 1) {
assert.equal(actions[i], mustBe[i]);
}
});