From f805a80bc1a7e0e6daa3b299b80cd470d8332c5a Mon Sep 17 00:00:00 2001
From: Michael Jumper <mjumper@apache.org>
Date: Sat, 11 Jan 2020 20:14:14 -0800
Subject: [PATCH] GUACAMOLE-249: Switch return type of guac_rdp_cache_bitmap()
 back to void - it doesn't fail, and isn't dictated by the FreeRDP API.

---
 src/protocols/rdp/bitmap.c | 4 +---
 src/protocols/rdp/bitmap.h | 5 +----
 2 files changed, 2 insertions(+), 7 deletions(-)

diff --git a/src/protocols/rdp/bitmap.c b/src/protocols/rdp/bitmap.c
index 61621f2e..db293162 100644
--- a/src/protocols/rdp/bitmap.c
+++ b/src/protocols/rdp/bitmap.c
@@ -31,7 +31,7 @@
 #include <stdio.h>
 #include <stdlib.h>
 
-BOOL guac_rdp_cache_bitmap(rdpContext* context, rdpBitmap* bitmap) {
+void guac_rdp_cache_bitmap(rdpContext* context, rdpBitmap* bitmap) {
 
     guac_client* client = ((rdp_freerdp_context*) context)->client;
     guac_rdp_client* rdp_client = (guac_rdp_client*) client->data;
@@ -59,8 +59,6 @@ BOOL guac_rdp_cache_bitmap(rdpContext* context, rdpBitmap* bitmap) {
     /* Store buffer reference in bitmap */
     ((guac_rdp_bitmap*) bitmap)->layer = buffer;
 
-    return TRUE;
-
 }
 
 BOOL guac_rdp_bitmap_new(rdpContext* context, rdpBitmap* bitmap) {
diff --git a/src/protocols/rdp/bitmap.h b/src/protocols/rdp/bitmap.h
index ef3e5476..297230c5 100644
--- a/src/protocols/rdp/bitmap.h
+++ b/src/protocols/rdp/bitmap.h
@@ -61,11 +61,8 @@ typedef struct guac_rdp_bitmap {
  *
  * @param bitmap
  *     The bitmap to cache.
- *
- * @return
- *     TRUE if successful, FALSE otherwise.
  */
-BOOL guac_rdp_cache_bitmap(rdpContext* context, rdpBitmap* bitmap);
+void guac_rdp_cache_bitmap(rdpContext* context, rdpBitmap* bitmap);
 
 /**
  * Initializes the given newly-created rdpBitmap.