pxcloud/guacamole-server
6
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

libguac: nested send instruction test

Browse Source 
Fix a race condition in the test.
The server is not waiting for the child to finish writing the message and this leads to a failed test if the child code is not running fast enough.

Signed-Off-By: Sven Auhagen <sven.auhagen@voleatech.de>
This commit is contained in:
sven 2024-02-01 08:47:42 +01:00 committed by GitHub
parent 73f23fc12c
commit bd5367ab3d
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/libguac/tests/socket/nested_send_instruction.c
View File

@ -22,6 +22,7 @@
#include <guacamole/socket.h>
#include <stdlib.h>
#include <sys/wait.h>
#include <unistd.h>
/**
@ -123,6 +124,7 @@ static void read_expected_instructions(int fd) {
void test_socket__nested_send_instruction() {
int fd[2];
int return_status;
/* Create pipe */
CU_ASSERT_EQUAL_FATAL(pipe(fd), 0);
@ -141,6 +143,9 @@ void test_socket__nested_send_instruction() {
exit(0);
}
/* Wait for child to finish */
waitpid(childpid, &return_status, 0);
/* Read and verify the expected instructions within the parent process */
close(write_fd);
read_expected_instructions(read_fd);