pxcloud/guacamole-server
5
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

GUACAMOLE-1971: Safely multiply values to be used for memory allocation.

Browse Source
This commit is contained in:
Alex Leitner 2024-07-22 10:34:00 -04:00
parent c715f16b0d
commit 98602294d9
No known key found for this signature in database
GPG Key ID: C8AF47D3CD30770E
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/protocols/rdp/pointer.c
View File

@ -29,6 +29,7 @@
#include <freerdp/freerdp.h>
#include <freerdp/gdi/gdi.h>
#include <guacamole/client.h>
#include <guacamole/mem.h>
#include <winpr/crt.h>
BOOL guac_rdp_pointer_new(rdpContext* context, rdpPointer* pointer) {
@ -41,7 +42,8 @@ BOOL guac_rdp_pointer_new(rdpContext* context, rdpPointer* pointer) {
rdp_client->display, pointer->width, pointer->height);
/* Allocate data for image */
unsigned char* data = _aligned_malloc(pointer->width * pointer->height * 4, 16);
unsigned char* data = _aligned_malloc(guac_mem_ckd_mul_or_die(pointer->width,
pointer->height, 4), 16);
cairo_surface_t* surface;
@ -122,4 +124,3 @@ BOOL guac_rdp_pointer_set_default(rdpContext* context) {
return TRUE;
}