From 6ecc5869542c0551e19dbb69ebd2caf2f673a29f Mon Sep 17 00:00:00 2001 From: Jimmy Date: Mon, 29 Jan 2024 00:14:27 -0800 Subject: [PATCH 1/2] GUACAMOLE-1912: Fix the spell errors in the identifiers of some constants with a wrong typo. --- src/libguac/error.c | 6 +++--- src/libguac/guacamole/error-types.h | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/libguac/error.c b/src/libguac/error.c index 21d34186..9be6ca0c 100644 --- a/src/libguac/error.c +++ b/src/libguac/error.c @@ -49,7 +49,7 @@ const char* __GUAC_STATUS_PERMISSION_DENIED_STR = "Permission denied"; const char* __GUAC_STATUS_BUSY_STR = "Resource busy"; const char* __GUAC_STATUS_NOT_AVAILABLE_STR = "Resource not available"; const char* __GUAC_STATUS_NOT_SUPPORTED_STR = "Not supported"; -const char* __GUAC_STATUS_NOT_INPLEMENTED_STR = "Not implemented"; +const char* __GUAC_STATUS_NOT_IMPLEMENTED_STR = "Not implemented"; const char* __GUAC_STATUS_TRY_AGAIN_STR = "Temporary failure"; const char* __GUAC_STATUS_PROTOCOL_ERROR_STR = "Protocol violation"; const char* __GUAC_STATUS_NOT_FOUND_STR = "Not found"; @@ -124,8 +124,8 @@ const char* guac_status_string(guac_status status) { return __GUAC_STATUS_NOT_SUPPORTED_STR; /* Not implemented */ - case GUAC_STATUS_NOT_INPLEMENTED: - return __GUAC_STATUS_NOT_INPLEMENTED_STR; + case GUAC_STATUS_NOT_IMPLEMENTED: + return __GUAC_STATUS_NOT_IMPLEMENTED_STR; /* Temporary failure */ case GUAC_STATUS_TRY_AGAIN: diff --git a/src/libguac/guacamole/error-types.h b/src/libguac/guacamole/error-types.h index 4cf3499e..3cd1ee62 100644 --- a/src/libguac/guacamole/error-types.h +++ b/src/libguac/guacamole/error-types.h @@ -116,7 +116,7 @@ typedef enum guac_status { /** * Support for the requested operation is not yet implemented. */ - GUAC_STATUS_NOT_INPLEMENTED, + GUAC_STATUS_NOT_IMPLEMENTED = 15, /** * The operation is temporarily unable to be performed, but may succeed if From 0cca39bed7653e88dd93a96cf6210b43f4c6d185 Mon Sep 17 00:00:00 2001 From: Jimmy Date: Mon, 29 Jan 2024 00:22:15 -0800 Subject: [PATCH 2/2] GUACAMOLE-1912: Add the constant containing a wrong type with a deprecation comment for maintaining API compatibility. --- src/libguac/guacamole/error-types.h | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/src/libguac/guacamole/error-types.h b/src/libguac/guacamole/error-types.h index 3cd1ee62..0a8172b6 100644 --- a/src/libguac/guacamole/error-types.h +++ b/src/libguac/guacamole/error-types.h @@ -113,6 +113,14 @@ typedef enum guac_status { */ GUAC_STATUS_NOT_SUPPORTED, + /** + * Support for the requested operation is not yet implemented. + * + * @deprecated This constant contains a typo in its name and will be + * removed in a future release. Use GUAC_STATUS_NOT_IMPLEMENTED instead. + */ + GUAC_STATUS_NOT_INPLEMENTED = 15, + /** * Support for the requested operation is not yet implemented. */