mirror of
https://git.proxmox.com/git/systemd
synced 2026-01-21 04:34:27 +00:00
Hi! I was trying out the journal and the journalctl utility sometimes crashed on me. After some debugging, I tracked it down to the fact that next_with_matches() holds the "c" object pointer through the journal_file_next_entry_for_data() call -- which apparently may re-map the journal file, invalidating the pointer. The attached patch fixes this crash for me, but being unfamiliar with the code, I don't know if I'm doing the right thing. This patch is also available from my github repository: git://github.com/intgr/systemd.git https://github.com/intgr/systemd Regards, Marti For the record, here's the original stack trace at the time of remapping: ret=0x7fff1d5cdec0) at src/journal/journal-file.c:330 ret=0x7fff1d5cdf28) at src/journal/journal-file.c:414 ret=0x7fff1d5ce0a0, offset=0x7fff1d5ce098) at src/journal/journal-file.c:1101 i=5705, ret=0x7fff1d5ce0a0, offset=0x7fff1d5ce098) at src/journal/journal-file.c:1147 p=6413608, data_offset=66600, direction=DIRECTION_DOWN, ret=0x7fff1d5ce0a0, offset=0x7fff1d5ce098) at src/journal/journal-file.c:1626 direction=DIRECTION_DOWN, ret=0x7fff1d5ce120, offset=0x7fff1d5ce128) at src/journal/sd-journal.c:533 direction=DIRECTION_DOWN, ret=0x7fff1d5ce170, offset=0x7fff1d5ce178) at src/journal/sd-journal.c:595 src/journal/sd-journal.c:651 From 9266fc6a58065a7c5dab67430fd78925e519dce9 Mon Sep 17 00:00:00 2001 From: Marti Raudsepp <marti@juffo.org> Date: Fri, 9 Mar 2012 16:23:00 +0200 Subject: [PATCH] journal: Don't hold pointers to journal while remapping This would cause a segfault otherwise. |
||
|---|---|---|
| m4 | ||
| man | ||
| po | ||
| src | ||
| sysctl.d | ||
| test | ||
| tmpfiles.d | ||
| units | ||
| .dir-locals.el | ||
| .gitignore | ||
| .mailmap | ||
| .vimrc | ||
| autogen.sh | ||
| CODING_STYLE | ||
| configure.ac | ||
| DISTRO_PORTING | ||
| introspect.awk | ||
| LICENSE | ||
| Makefile.am | ||
| NEWS | ||
| README | ||
| TODO | ||
systemd System and Service Manager
DETAILS:
http://0pointer.de/blog/projects/systemd.html
WEB SITE:
http://www.freedesktop.org/wiki/Software/systemd
GIT:
git://anongit.freedesktop.org/systemd/systemd
ssh://git.freedesktop.org/git/systemd/systemd
GITWEB:
http://cgit.freedesktop.org/systemd/systemd
MAILING LIST:
http://lists.freedesktop.org/mailman/listinfo/systemd-devel
http://lists.freedesktop.org/mailman/listinfo/systemd-commits
IRC:
#systemd on irc.freenode.org
BUG REPORTS:
https://bugs.freedesktop.org/enter_bug.cgi?product=systemd
AUTHOR:
Lennart Poettering with major support from Kay Sievers
LICENSE:
GPLv2+ for all code, except sd-daemon.[ch] and
sd-readahead.[ch] which are MIT
REQUIREMENTS:
Linux kernel >= 2.6.39
with devtmpfs
with cgroups (but it's OK to disable all controllers)
optional but strongly recommended: autofs4, ipv6
libudev >= 172
dbus >= 1.4.0
libcap
gtk+ >= 2.20 (optional)
PAM >= 1.1.2 (optional)
libcryptsetup (optional)
libaudit (optional)
libselinux (optional)
tcpwrappers (optional)
libnotify (optional)
When you build from git you need the following additional dependencies:
vala >= 0.10
docbook-xsl
xsltproc
automake
autoconf
libtool
gperf
make, gcc, and similar tools
During runtime you need the following dependencies:
util-linux > v2.18 (requires fsck -l, agetty -s)
sulogin (from sysvinit-tools, optional but recommended)
plymouth (optional)
dracut (optional)
When systemd-hostnamed is used it is strongly recommended to
install nss-myhostname to ensure that in a world of
dynamically changing hostnames the hostname stays resolveable
under all circumstances. In fact, systemd-hostnamed will warn
if nss-myhostname is not installed. Packagers are encouraged to
add a dependency on nss-myhostname to the package that
includes systemd-hostnamed.
Note that D-Bus can link against libsystemd-login.so, which
results in a cyclic build dependency. To accomodate for this
please build D-Bus without systemd first, then build systemd,
then rebuild D-Bus with systemd support.
WARNINGS:
systemd will warn you during boot if /etc/mtab is not a
symlink to /proc/mounts. Please ensure that /etc/mtab is a
proper symlink.
systemd will warn you during boot if /usr is on a different
file system than /. While in systemd itself very little will
break if /usr is on a separate partition many of its
dependencies very likely will break sooner or later in one
form or another. For example udev rules tend to refer to
binaries in /usr, binaries that link to libraries in /usr or
binaries that refer to data files in /usr. Since these
breakages are not always directly visible systemd will warn
about this, since this kind of file system setup is not really
supported anymore by the basic set of Linux OS components.
For more information on this issue consult
http://freedesktop.org/wiki/Software/systemd/separate-usr-is-broken
ENGINEERING AND CONSULTING SERVICES:
ProFUSION <http://profusion.mobi> offers professional
engineering and consulting services for systemd for embedded
and other use. Please contact Gustavo Barbieri
<barbieri@profusion.mobi> for more information.
Disclaimer: This notice is not a recommendation or official
endorsement. However, ProFUSION's upstream work has been very
beneficial for the systemd project.