proxmox-mirrors/qemu
1
0
Fork 0
mirror of https://git.proxmox.com/git/qemu synced 2025-08-15 08:04:12 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

scsi: do not require a minimum allocation length for REQUEST SENSE

Browse Source 
The requirements on the REQUEST SENSE buffer size are not in my copy of SPC
(SPC-4 r27) and not observed by LIO.  Rip them out.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
This commit is contained in:
Paolo Bonzini 2012-05-03 15:57:08 +02:00
parent 3c3d8a95ca
commit e5f38ff6f5
1 changed files with 2 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
hw/scsi-bus.c
View File

@ -427,9 +427,6 @@ static int32_t scsi_target_send_command(SCSIRequest *req, uint8_t *buf)
} }
break; break;
case REQUEST_SENSE: case REQUEST_SENSE:
if (req->cmd.xfer < 4) {
goto illegal_request;
}
r->len = scsi_device_get_sense(r->req.dev, r->buf, r->len = scsi_device_get_sense(r->req.dev, r->buf,
MIN(req->cmd.xfer, sizeof r->buf), MIN(req->cmd.xfer, sizeof r->buf),
(req->cmd.buf[1] & 1) == 0); (req->cmd.buf[1] & 1) == 0);
@ -538,8 +535,8 @@ SCSIRequest *scsi_req_new(SCSIDevice *d, uint32_t tag, uint32_t lun,
req = scsi_req_alloc(&reqops_unit_attention, d, tag, lun, req = scsi_req_alloc(&reqops_unit_attention, d, tag, lun,
hba_private); hba_private);
} else if (lun != d->lun || } else if (lun != d->lun ||
buf[0] == REPORT_LUNS || buf[0] == REPORT_LUNS ||
(buf[0] == REQUEST_SENSE && (d->sense_len || cmd.xfer < 4))) { (buf[0] == REQUEST_SENSE && d->sense_len)) {
req = scsi_req_alloc(&reqops_target_command, d, tag, lun, req = scsi_req_alloc(&reqops_target_command, d, tag, lun,
hba_private); hba_private);
} else { } else {